WHQL didn’t test prefast. Consider using prefast annotations to
eliminate the prefast warnings that you know are bogus.
-----Original Message-----
From: xxxxx@lists.osr.com
[mailto:xxxxx@lists.osr.com] On Behalf Of hakim
Sent: Wednesday, March 14, 2007 12:47 PM
To: Windows System Software Devs Interest List
Subject: Re:[ntdev] prefast
Warnings are invalid, for example
The function ‘SerialFlush’ changes the IRQL and does not restore the
IRQL
before it exits. It should be annotated to reflect the change or the
IRQL
should be restored. IRQL was last set to 2 at line 96.
Found in function ‘SerialFlush’
The lock is released in another routine.
Another one
The function ‘SerialFlush’ has been declared to be in a paged segment,
but
neither PAGED_CODE nor PAGED_CODE_LOCKED was found.
The declaration for paged segment made as macro
SERIAL_LOCKED_PAGED_CODE()
and called at the beginning of the routine.
I fixed all reasonable warnings and the remaining warnings are like this
and
fixing them will take significant amount time for no good reason, the
drivers are running in 2000/XP/2003 server for years and WHQLed too by
HCT.
Thanks,
Hakim
“Don Burn” wrote in message news:xxxxx@ntdev…
> Well, preFast only gives warnings. I have not tried the final WDK
code,
> but there were a number of samples in the beta the preFast gave valid
> warnings (things like the code was dereferencing a NULL pointer).
The
> simplest and safest thing is fix all the warnings from preFast.
>
> –
> Don Burn (MVP, Windows DDK)
> Windows 2k/XP/2k3 Filesystem and Driver Consulting
> Website: http://www.windrvr.com
> Blog: http://msmvps.com/blogs/WinDrvr
> Remove StopSpam to reply
>
>
> “hakim” wrote in message news:xxxxx@ntdev…
>> My prefast logs have warnings, no errors. My driver is based off
standard
>> serial and toaster bus driver source and I ran prefast on WDK’s
serial
>> source and toaster bus driver found the exact same warnings.
>>
>> BTW, I just found Microsoft DTM newgroup is up from March 12 which I
>> didn’t check before posting.
>>
>> Thanks,
>> Hakim
>>
>> “Don Burn” wrote in message news:xxxxx@ntdev…
>>> Well the first question would be is your driver preFast clean under
both
>>> 32 and 64 bit builds? Since 64 bit can impact things preFast checks
>>> for, if you are not clean under both …
>>>
>>>
>>> –
>>> Don Burn (MVP, Windows DDK)
>>> Windows 2k/XP/2k3 Filesystem and Driver Consulting
>>> Website: http://www.windrvr.com
>>> Blog: http://msmvps.com/blogs/WinDrvr
>>> Remove StopSpam to reply
>>>
>>> “hakim” wrote in message news:xxxxx@ntdev…
>>>> Hi,
>>>>
>>>> Pesky DTM again. With all the QFE fixes all tests now pass for
my
>>>> unclassified device in Vista 64 bit but not prefast. I have two sys
>>>> files in the package so I have two log files (they are named same
as
>>>> binary sys file as suggested in DTM doc), the bus driver log file
>>>> passed but the port driver log file failed. Then I made a fresh new
>>>> submission test, test prefast and now none of them pass, I retested
and
>>>> the same result. The same test passed in 32 bit testing, so I
thought
>>>> 64 bit testing would pass but I’m wrong and free support for DTM is
>>>> gone.
>>>>
>>>> Anyone has any idea for a workaround?
>>>>
>>>> Thanks,
>>>> Hakim
>>>>
>>>>
*********************************
>>>>
>>>>
>>>> The Execute Task with Commandline
>>>>
>>>> cmd /c PFDTest.cmd
>>>>
>>>> Failed with ExitCode 1
>>>>
>>>>
>>>> Resolution
>>>> The task exited with an ExitCode other than the
>>>> ExpectedTaskExitCode. This may cause the Task to Fail if it is set
to
>>>> Fail On Exit Code
>>>>
>>>>
>>>> Test Log Report - Summary
>>>>
>>>> Report Summary
>>>> Test Results
>>>> Description Total Pass Fail Warning Blocked Skipped Pass Rate
>>>> 1 0 1 0 0 0 0.00%
>>>> TimeStamp Total Pass Fail Warning Blocked Skipped Pass Rate
>>>> 3/14/2007 10:32:00.272 AM 1 0 1 0 0 0 0.00%
>>>>
>>>> Machine, Process, and OS Information
>>>> Machine Name OS Version Build VBL BuildDate Platform Language
>>>> ServicePack Config
>>>> Windows Vista ™ Ultimate 6.0 5744.00 061003-1945 AMD64
>>>> English (US) (REDMOND) n/a
>>>> Base Time Process ID Thread ID Process Name
>>>> 3/14/2007 10:32:00.272 AM 1032 1304
>>>>
C:\WTT\JobsWorkingDir\Tasks\WTTJobRun43A6E47B-1AEF-4121-8BFA-6A85308DC65
E\PfdSdvWrapper.exe
>>>>
>>>> Report Details
>>>> Summary Of Test Results
>>>> Ending Time Result Title TUID
>>>> 3/14/2007 10:32:00.272 AM Failed Checking for CommandLine
>>>> Arguments Information
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>>
>>
>
>
>
—
Questions? First check the Kernel Driver FAQ at
http://www.osronline.com/article.cfm?id=256
To unsubscribe, visit the List Server section of OSR Online at
http://www.osronline.com/page.cfm?name=ListServer