Windows System Software -- Consulting, Training, Development -- Unique Expertise, Guaranteed Results

Home NTDEV
Before Posting...
Please check out the Community Guidelines in the Announcements and Administration Category.

More Info on Driver Writing and Debugging


The free OSR Learning Library has more than 50 articles on a wide variety of topics about writing and debugging device drivers and Minifilters. From introductory level to advanced. All the articles have been recently reviewed and updated, and are written using the clear and definitive style you've come to expect from OSR over the years.


Check out The OSR Learning Library at: https://www.osr.com/osr-learning-library/


ZwOpenProcess handle leak

OSR_Community_UserOSR_Community_User Member Posts: 110,217
in ZwOpenProcess manual
https://msdn.microsoft.com/en-us/library/windows/hardware/ff567022(v=vs.85).aspx
it is not mentioned that you need to close the handle, but when I use it, seems like if I don't close the handle there is a handle leak.

for (int i = 0; i < 10; i++)
{
HANDLE hProcess = 0;
NTSTATUS status = STATUS_SUCCESS;
OBJECT_ATTRIBUTES obj_attr;
InitializeObjectAttributes(&obj_attr, NULL, 0, NULL, NULL);
CLIENT_ID cid;
cid.UniqueProcess = ProcessId;
cid.UniqueThread = (HANDLE)0;
status = ZwOpenProcess(&hProcess, GENERIC_ALL, &obj_attr, &cid);
DbgPrint("ZwOpenProcess: status:%x, handle: %x\n", status, hProcess);
//ZwClose(hProcess);
}

output:
ZwOpenProcess: status:0, handle: 9c
ZwOpenProcess: status:0, handle: 60
ZwOpenProcess: status:0, handle: a0
ZwOpenProcess: status:0, handle: 70
ZwOpenProcess: status:0, handle: a4
ZwOpenProcess: status:0, handle: a8
ZwOpenProcess: status:0, handle: ac
ZwOpenProcess: status:0, handle: b0
ZwOpenProcess: status:0, handle: b4
ZwOpenProcess: status:0, handle: b8

if I close the handle after the call to DbgPrint, there is no handle leak

for (int i = 0; i < 10; i++)
{
HANDLE hProcess = 0;
NTSTATUS status = STATUS_SUCCESS;
OBJECT_ATTRIBUTES obj_attr;
InitializeObjectAttributes(&obj_attr, NULL, 0, NULL, NULL);
CLIENT_ID cid;
cid.UniqueProcess = ProcessId;
cid.UniqueThread = (HANDLE)0;
status = ZwOpenProcess(&hProcess, GENERIC_ALL, &obj_attr, &cid);
DbgPrint("ZwOpenProcess: status:%x, handle: %x\n", status, hProcess);
ZwClose(hProcess);
}

output:
ZwOpenProcess: status:0, handle: 60
ZwOpenProcess: status:0, handle: 60
ZwOpenProcess: status:0, handle: 60
ZwOpenProcess: status:0, handle: 60
ZwOpenProcess: status:0, handle: 60
ZwOpenProcess: status:0, handle: 60
ZwOpenProcess: status:0, handle: 60
ZwOpenProcess: status:0, handle: 60
ZwOpenProcess: status:0, handle: 60
ZwOpenProcess: status:0, handle: 60


is the MS document incomplete or am I missing something?

Comments

Sign In or Register to comment.

Howdy, Stranger!

It looks like you're new here. If you want to get involved, click one of these buttons!

Upcoming OSR Seminars
OSR has suspended in-person seminars due to the Covid-19 outbreak. But, don't miss your training! Attend via the internet instead!
Kernel Debugging 30 Mar 2020 OSR Seminar Space
Developing Minifilters 15 Jun 2020 LIVE ONLINE
Writing WDF Drivers 22 June 2020 LIVE ONLINE
Internals & Software Drivers 28 Sept 2020 Dulles, VA